Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: introduce SnapModel #1290

Merged
merged 3 commits into from
Jul 21, 2023
Merged

refactor: introduce SnapModel #1290

merged 3 commits into from
Jul 21, 2023

Conversation

d-loose
Copy link
Member

@d-loose d-loose commented Jul 21, 2023

UDENG-791, UDENG-796

Replaces the snap providers with an old-fashioned ChangeNotifier.
I consider moving more of the presentation logic from the detail page into the view model later on.

@anasereijo we'd need your input on what snap metadata should be shown on the app page depending on:

  • whether a snap is already installed
  • whether a snap is available in the store
  • which channel is currently selected
  • any combination of the above

@d-loose d-loose requested a review from jpnurmi July 21, 2023 10:27
Copy link
Member

@jpnurmi jpnurmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LVGTM 👍

@d-loose d-loose merged commit aedfad2 into ubuntu:dev Jul 21, 2023
6 checks passed
tim-hm pushed a commit to tim-hm/app-center that referenced this pull request Sep 1, 2023
* refactor: replace snap providers with SnapModel

* test: remove detail_provider_test

* test: separate snap_model_test from detail_page_test
tim-hm pushed a commit to tim-hm/app-center that referenced this pull request Sep 1, 2023
* refactor: replace snap providers with SnapModel

* test: remove detail_provider_test

* test: separate snap_model_test from detail_page_test
@d-loose d-loose deleted the snap-model branch September 19, 2023 21:02
ashuntu pushed a commit to ashuntu/app-center that referenced this pull request Feb 28, 2024
* refactor: replace snap providers with SnapModel

* test: remove detail_provider_test

* test: separate snap_model_test from detail_page_test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants